scl/strato
1
0
Fork 0
mirror of https://github.com/Takiiiiiiii/strato.git synced 2025-07-17 08:46:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize Buffer Lookups using Range Tables

Browse Source 
Buffer lookups are a fairly expensive operation that we currently spend `O(log n)` on the simplest and most frequent case of which is a direct match, this is a very frequent operation where that may be insufficient. This commit optimizes that case to `O(1)` by utilizing a `RangeTable` at the cost of slightly higher insertion/deletion costs for setting ranges of values but these are minimal in frequency compared to lookups.
This commit is contained in:
PixelyIon
2022-08-01 21:50:09 +05:30
parent 578ae86cca
commit 5f8619f791
2 changed files with 28 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/src/main/cpp/skyline/gpu/buffer_manager.h
View File

@ -3,6 +3,7 @@
#pragma once
#include <common/range_table.h>
#include "buffer.h"
namespace skyline::gpu {
@ -15,7 +16,12 @@ namespace skyline::gpu {
private:
GPU &gpu;
std::mutex mutex; //!< Synchronizes access to the buffer mappings
std::vector<std::shared_ptr<Buffer>> buffers; //!< A sorted vector of all buffer mappings
std::vector<std::shared_ptr<Buffer>> bufferMappings; //!< A sorted vector of all buffer mappings
static constexpr size_t AddressSpaceSize{1ULL << 39}; //!< The size of the guest CPU AS in bytes
static constexpr size_t PageSizeBits{12}; //!< The size of a single page of the guest CPU AS as a power of two (4 KiB == 1 << 12)
static constexpr size_t L2EntryGranularity{19}; //!< The amount of AS (in bytes) a single L2 PTE covers (512 KiB == 1 << 19)
RangeTable<Buffer*, AddressSpaceSize, PageSizeBits, L2EntryGranularity> bufferTable; //!< A page table of all buffer mappings for O(1) lookups on full matches
std::mutex megaBufferMutex; //!< Synchronizes access to the allocated megabuffers
@ -57,11 +63,13 @@ namespace skyline::gpu {
/**
* @brief Inserts the supplied buffer into the map based on its guest address
* @note The supplied buffer **must** have a valid guest mapping
*/
void InsertBuffer(std::shared_ptr<Buffer> buffer);
/**
* @brief Deletes the supplied buffer from the map, the lifetime of the buffer will no longer be extended by the map
* @note The supplied buffer **must** have a valid guest mapping
*/
void DeleteBuffer(const std::shared_ptr<Buffer> &buffer);