From 6a57fd16fbdb98e6bcdda58ceb162cbcdce00968 Mon Sep 17 00:00:00 2001 From: Billy Laws Date: Wed, 5 Apr 2023 20:13:18 +0100 Subject: [PATCH] Don't bail out when invalid desc types are encountered This caused graphical artifacts and didn't particularly help prevent crashes. --- .../skyline/gpu/interconnect/maxwell_3d/pipeline_manager.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/pipeline_manager.cpp b/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/pipeline_manager.cpp index ea6b8df3..3bb78d57 100644 --- a/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/pipeline_manager.cpp +++ b/app/src/main/cpp/skyline/gpu/interconnect/maxwell_3d/pipeline_manager.cpp @@ -836,10 +836,6 @@ namespace skyline::gpu::interconnect::maxwell3d { bindingIdx += stage.storageImageDescs.size(); } - // Since we don't implement all descriptor types the number of writes might not match what's expected - if (!writeIdx) - return nullptr; - return ctx.executor.allocator->EmplaceUntracked(DescriptorUpdateInfo{ .writes = writes.first(writeIdx), .bufferDescs = bufferDescs.first(bufferIdx),