Avoid trapping frequently synced buffers by using megabuffer copies

When a buffer is trapped nearly every frame, the cost of trapping and synchronising its contents starts to quickly add up. By always using the megabuffer when this is the case, since megabuffer copies are done directly from the guest, we skip the need to synchronise/trap the backing.
This commit is contained in:
Billy Laws
2022-09-17 12:53:50 +01:00
parent a24aec03a6
commit 99a34df4cc
3 changed files with 4 additions and 2 deletions

View File

@ -279,7 +279,7 @@ namespace skyline::gpu {
// Bail out if buffer cannot be synced, we don't know the contents ahead of time so the sequence is indeterminate
return {};
if (!everHadInlineUpdate)
if (!everHadInlineUpdate && sequenceNumber < FrequentlySyncedThreshold)
// Don't megabuffer buffers that have never had inline updates and are not frequently synced since performance is only going to be harmed as a result of the constant copying and there wont be any benefit since there are no GPU inline updates that would be avoided
return {};