From b08c6eca260be33422d82ff18bebd78898894d74 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Fri, 19 May 2023 02:00:16 +0200
Subject: [PATCH 01/30] client/comments: prevent avatar focus outline from
 being clipped

---
 client/css/comment-control.styl | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/client/css/comment-control.styl b/client/css/comment-control.styl
index 0d5959bb..9fece4c3 100644
--- a/client/css/comment-control.styl
+++ b/client/css/comment-control.styl
@@ -16,7 +16,13 @@ $comment-border-color = #DDD
             width: 40px
             height: 40px
         a
+            outline: none
             display: inline-block
+            position: relative
+            top: -2px
+            border: 2px solid transparent
+            &:focus
+                border: 2px solid $main-color
 
     nav:not(.active), .tab:not(.active)
         display: none

From 9588d11cb083746dcf34be294c538340c8531c0a Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Fri, 19 May 2023 19:29:57 +0200
Subject: [PATCH 02/30] client/css: gray out disabled radio button circle

---
 client/css/core-forms.styl | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/client/css/core-forms.styl b/client/css/core-forms.styl
index ee21ed1b..c75e81ae 100644
--- a/client/css/core-forms.styl
+++ b/client/css/core-forms.styl
@@ -125,6 +125,9 @@ input[type=radio]:checked + .radio:after,
 input[type=checkbox]:checked + .checkbox:after
     opacity: 1
 
+input[type=radio]:disabled + .radio:after
+    background: $input-disabled-text-color
+
 input[type=radio]:disabled + .radio:before,
 input[type=checkbox]:disabled + .checkbox:before,
 input[type=radio]:disabled + .radio:after,

From 4c6d1a216ba09bfe308dc02edc583fd8779d6e3d Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Fri, 19 May 2023 16:56:52 +0200
Subject: [PATCH 03/30] client/css: space out similar posts on upload page

---
 client/css/post-upload.styl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/client/css/post-upload.styl b/client/css/post-upload.styl
index cb6b0067..7b8b14b0 100644
--- a/client/css/post-upload.styl
+++ b/client/css/post-upload.styl
@@ -145,6 +145,7 @@ $cancel-button-color = tomato
                             clear: both
                             margin: 1em 0 0 0
                             padding-left: 7em
+                            padding-bottom: 1em;
                             font-size: 90%
 
                             .thumbnail-wrapper

From a8b6c143ebf5c6cf02deff2c7ea1b1f4635d557d Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Thu, 25 May 2023 19:12:49 +0200
Subject: [PATCH 04/30] client/css: use text color for home footer bullets

---
 client/css/home-view.styl | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/client/css/home-view.styl b/client/css/home-view.styl
index 729fac0c..b0666be0 100644
--- a/client/css/home-view.styl
+++ b/client/css/home-view.styl
@@ -61,7 +61,10 @@
                 word-spacing: 1.1em
                 background-repeat: no-repeat
                 background-position: 50% 50%
-                background-image: url("data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' width='12' height='12'><circle cx='6' cy='6' r='2' fill='%23000000'/></svg>")
+                background-image: url("data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' width='12' height='12'><circle cx='6' cy='6' r='2' fill='%23111111'/></svg>")
 
     .thumbnail
         margin-right: 0.4em
+
+.darktheme #home footer ul .sep
+    background-image: url("data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' width='12' height='12'><circle cx='6' cy='6' r='2' fill='%23e6e6e6'/></svg>")
\ No newline at end of file

From 5d1dbb291c60df05f990b7f818ddd1fd609d1ec0 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Wed, 17 May 2023 20:38:50 +0200
Subject: [PATCH 05/30] client/markdown: allow markdown headers This regex
 caught more than was necessary, and in the process made it impossible to use
 headers. Only replace instances that will actually trigger tag permalinks.

---
 client/js/util/markdown.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/js/util/markdown.js b/client/js/util/markdown.js
index e71e3263..90cd10f2 100644
--- a/client/js/util/markdown.js
+++ b/client/js/util/markdown.js
@@ -54,7 +54,7 @@ class TildeWrapper extends BaseMarkdownWrapper {
 // prevent ^#... from being treated as headers, due to tag permalinks
 class TagPermalinkFixWrapper extends BaseMarkdownWrapper {
     preprocess(text) {
-        return text.replace(/^#/g, "%%%#");
+        return text.replace(/^#(?=[a-zA-Z0-9_-])/g, "%%%#");
     }
 
     postprocess(text) {

From ae9e5960955418e754f414c39eff192b2223b45c Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Thu, 18 May 2023 23:01:39 +0200
Subject: [PATCH 06/30] client/notes: remove interaction with main overlay area
 Right click Copy would not work on Chrome and Firefox. Right click Save would
 not work on Firefox.

---
 client/css/post-notes-overlay-control.styl | 2 ++
 client/html/post_content.tpl               | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/client/css/post-notes-overlay-control.styl b/client/css/post-notes-overlay-control.styl
index a3bc4793..ca38a451 100644
--- a/client/css/post-notes-overlay-control.styl
+++ b/client/css/post-notes-overlay-control.styl
@@ -18,6 +18,8 @@
             right: 0
             top: 0
             bottom: 0
+    &[data-state=read-only]
+        pointer-events: none
 
 .notes-overlay
     g
diff --git a/client/html/post_content.tpl b/client/html/post_content.tpl
index fd5b094c..18141c4f 100644
--- a/client/html/post_content.tpl
+++ b/client/html/post_content.tpl
@@ -1,7 +1,7 @@
 <div class='post-content post-type-<%- ctx.post.type %>'>
     <% if (['image', 'animation'].includes(ctx.post.type)) { %>
 
-        <img class='resize-listener' alt='' src='<%- ctx.post.contentUrl %>'/>
+        <img class='resize-listener' alt='' src='<%- ctx.post.contentUrl %>' draggable='false'/>
 
     <% } else if (ctx.post.type === 'flash') { %>
 

From 486fc345fe16adfc3368988bd492acef6e9ed865 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Wed, 17 May 2023 21:55:30 +0200
Subject: [PATCH 07/30] client/pools, client/tags: move description before
 details

---
 client/html/pool_summary.tpl | 12 ++++++------
 client/html/tag_summary.tpl  | 12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/client/html/pool_summary.tpl b/client/html/pool_summary.tpl
index 8f4e27d0..a81808dd 100644
--- a/client/html/pool_summary.tpl
+++ b/client/html/pool_summary.tpl
@@ -1,4 +1,10 @@
 <div class='content-wrapper pool-summary'>
+    <section class='description'>
+        <%= ctx.makeMarkdown(ctx.pool.description || 'This pool has no description yet.') %>
+        <p>This pool has <a href='<%- ctx.formatClientLink('posts', {query: 'pool:' + ctx.pool.id}) %>'><%- ctx.pool.postCount %> post(s)</a>.</p>
+        <hr/>
+    </section>
+
     <section class='details'>
         <section>
             Category:
@@ -14,10 +20,4 @@
         --></ul>
         </section>
     </section>
-
-    <section class='description'>
-        <hr/>
-        <%= ctx.makeMarkdown(ctx.pool.description || 'This pool has no description yet.') %>
-        <p>This pool has <a href='<%- ctx.formatClientLink('posts', {query: 'pool:' + ctx.pool.id}) %>'><%- ctx.pool.postCount %> post(s)</a>.</p>
-    </section>
 </div>
diff --git a/client/html/tag_summary.tpl b/client/html/tag_summary.tpl
index 06e25479..5bd595e1 100644
--- a/client/html/tag_summary.tpl
+++ b/client/html/tag_summary.tpl
@@ -1,4 +1,10 @@
 <div class='content-wrapper tag-summary'>
+    <section class='description'>
+        <%= ctx.makeMarkdown(ctx.tag.description || 'This tag has no description yet.') %>
+        <p>This tag has <a href='<%- ctx.formatClientLink('posts', {query: ctx.escapeTagName(ctx.tag.names[0])}) %>'><%- ctx.tag.postCount %> usage(s)</a>.</p>
+        <hr/>
+    </section>
+
     <section class='details'>
         <section>
             Category:
@@ -32,10 +38,4 @@
         --></ul>
         </section>
     </section>
-
-    <section class='description'>
-        <hr/>
-        <%= ctx.makeMarkdown(ctx.tag.description || 'This tag has no description yet.') %>
-        <p>This tag has <a href='<%- ctx.formatClientLink('posts', {query: ctx.escapeTagName(ctx.tag.names[0])}) %>'><%- ctx.tag.postCount %> usage(s)</a>.</p>
-    </section>
 </div>

From f590dc6a41353f538cb2ed259c3130c2a7fe2004 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Wed, 17 May 2023 21:45:48 +0200
Subject: [PATCH 08/30] client/pools, client/tags: obvious button to access
 posts list

---
 client/css/core-general.styl | 5 +++++
 client/html/pool.tpl         | 1 +
 client/html/tag.tpl          | 1 +
 3 files changed, 7 insertions(+)

diff --git a/client/css/core-general.styl b/client/css/core-general.styl
index 7e5883aa..430848b7 100644
--- a/client/css/core-general.styl
+++ b/client/css/core-general.styl
@@ -106,6 +106,11 @@ form .fa-question-circle-o
                     background-color: $scrollbar-bg-color
                 &::-webkit-scrollbar-thumb
                     background-color: $scrollbar-thumb-color
+                li[data-name=view]
+                    background: $button-enabled-background-color
+                    margin-right: 1em
+                    a
+                        color: $button-enabled-text-color
     >.content-wrapper:not(.transparent)
         background: $top-navigation-color
         padding: 1.8em
diff --git a/client/html/pool.tpl b/client/html/pool.tpl
index 831d07c6..e368c066 100644
--- a/client/html/pool.tpl
+++ b/client/html/pool.tpl
@@ -2,6 +2,7 @@
     <h1><%- ctx.getPrettyName(ctx.pool.names[0]) %></h1>
     <nav class='buttons'><!--
         --><ul><!--
+            --><li data-name='view'><a href='<%- ctx.formatClientLink('posts', {query: 'pool:' + ctx.pool.id}) %>'>View</a></li><!--
             --><li data-name='summary'><a href='<%- ctx.formatClientLink('pool', ctx.pool.id) %>'>Summary</a></li><!--
             --><% if (ctx.canEditAnything) { %><!--
                 --><li data-name='edit'><a href='<%- ctx.formatClientLink('pool', ctx.pool.id, 'edit') %>'>Edit</a></li><!--
diff --git a/client/html/tag.tpl b/client/html/tag.tpl
index d84e299e..28189ee5 100644
--- a/client/html/tag.tpl
+++ b/client/html/tag.tpl
@@ -2,6 +2,7 @@
     <h1><%- ctx.getPrettyName(ctx.tag.names[0]) %></h1>
     <nav class='buttons'><!--
         --><ul><!--
+            --><li data-name='view'><a href='<%- ctx.formatClientLink('posts', {query: ctx.escapeTagName(ctx.tag.names[0])}) %>'>View</a></li><!--
             --><li data-name='summary'><a href='<%- ctx.formatClientLink('tag', ctx.tag.names[0]) %>'>Summary</a></li><!--
             --><% if (ctx.canEditAnything) { %><!--
                 --><li data-name='edit'><a href='<%- ctx.formatClientLink('tag', ctx.tag.names[0], 'edit') %>'>Edit</a></li><!--

From b8b51ded15fe9b6e0bd1b9c91fcfb5e6d2c70ac1 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Fri, 26 May 2023 09:37:33 +0200
Subject: [PATCH 09/30] client/pools: display error message on merge page when
 no pool selected Also fixes a js error.

---
 client/js/views/pool_merge_view.js | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/client/js/views/pool_merge_view.js b/client/js/views/pool_merge_view.js
index f0ca15a3..5cde2ed5 100644
--- a/client/js/views/pool_merge_view.js
+++ b/client/js/views/pool_merge_view.js
@@ -58,6 +58,11 @@ class PoolMergeView extends events.EventTarget {
 
     _evtSubmit(e) {
         e.preventDefault();
+        if (!this._targetPoolId) {
+            this.clearMessages();
+            this.showError("You must select a pool name from autocomplete.");
+            return;
+        }
         this.dispatchEvent(
             new CustomEvent("submit", {
                 detail: {

From 08bd3bb8905abd815424dbc42e8e404f5f0de176 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Wed, 26 Mar 2025 20:49:11 +0100
Subject: [PATCH 10/30] client/posts: better drag alt text on chrome

---
 client/html/posts_page.tpl | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/client/html/posts_page.tpl b/client/html/posts_page.tpl
index 52011ad1..946ea905 100644
--- a/client/html/posts_page.tpl
+++ b/client/html/posts_page.tpl
@@ -10,28 +10,27 @@
                         <span class='type' data-type='<%- post.type %>'>
                             <% if (post.type == 'video' || post.type == 'flash' || post.type == 'animation') { %>
                                 <span class='icon'><i class='fa fa-film'></i></span>
-                            <% } else { %>
-                                <%- post.type %>
                             <% } %>
+                            <%- post.type %>
                         </span>
                         <% if (post.score || post.favoriteCount || post.commentCount) { %>
                             <span class='stats'>
                                 <% if (post.score) { %>
                                     <span class='icon'>
                                         <i class='fa fa-thumbs-up'></i>
-                                        <%- post.score %>
+                                        <span style="display: none">score:</span><%- post.score %>
                                     </span>
                                 <% } %>
                                 <% if (post.favoriteCount) { %>
                                     <span class='icon'>
                                         <i class='fa fa-heart'></i>
-                                        <%- post.favoriteCount %>
+                                        <span style="display: none">favorites:</span><%- post.favoriteCount %>
                                     </span>
                                 <% } %>
                                 <% if (post.commentCount) { %>
                                     <span class='icon'>
                                         <i class='fa fa-commenting'></i>
-                                        <%- post.commentCount %>
+                                        <span style="display: none">comments:</span><%- post.commentCount %>
                                     </span>
                                 <% } %>
                             </span>

From a9d870eaa85128fc94dcd52678eba268470bc604 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Sat, 23 Mar 2024 16:59:52 +0100
Subject: [PATCH 11/30] client/posts: don't crash on edit mode when no
 permissions

---
 client/js/controls/post_edit_sidebar_control.js | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/client/js/controls/post_edit_sidebar_control.js b/client/js/controls/post_edit_sidebar_control.js
index eabb98ae..46f56c6d 100644
--- a/client/js/controls/post_edit_sidebar_control.js
+++ b/client/js/controls/post_edit_sidebar_control.js
@@ -224,10 +224,12 @@ class PostEditSidebarControl extends events.EventTarget {
             });
         }
 
-        this._tagControl.addEventListener("change", (e) => {
-            this.dispatchEvent(new CustomEvent("change"));
-            this._syncExpanderTitles();
-        });
+        if (this._tagControl) {
+            this._tagControl.addEventListener("change", (e) => {
+                this.dispatchEvent(new CustomEvent("change"));
+                this._syncExpanderTitles();
+            });
+        }
 
         if (this._noteTextareaNode) {
             this._noteTextareaNode.addEventListener("change", (e) =>

From 20e03e1397814679ff1b65622f72cdb6b0c6fc4e Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Fri, 19 May 2023 18:47:09 +0200
Subject: [PATCH 12/30] client/posts: force file download for download button
 So that it works regardless of server configuration.

---
 client/html/post_readonly_sidebar.tpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/html/post_readonly_sidebar.tpl b/client/html/post_readonly_sidebar.tpl
index 0f93ae3b..6e10672a 100644
--- a/client/html/post_readonly_sidebar.tpl
+++ b/client/html/post_readonly_sidebar.tpl
@@ -1,7 +1,7 @@
 <div class='readonly-sidebar'>
     <article class='details'>
         <section class='download'>
-            <a rel='external' href='<%- ctx.post.contentUrl %>'>
+            <a href='<%- ctx.post.contentUrl %>' download>
                 <i class='fa fa-download'></i><!--
             --><%= ctx.makeFileSize(ctx.post.fileSize) %> <!--
                 --><%- {

From e05252f67ee7969a8fad1d478c0b454ec8449226 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Wed, 17 May 2023 10:04:33 +0200
Subject: [PATCH 13/30] client/posts: hide edit icon when unprivileged

---
 client/html/post_main.tpl | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/client/html/post_main.tpl b/client/html/post_main.tpl
index 54c57333..62a009b0 100644
--- a/client/html/post_main.tpl
+++ b/client/html/post_main.tpl
@@ -29,6 +29,7 @@
                     <span class='vim-nav-hint'>Next post &gt;</span>
                 </a>
             </article>
+            <% if (ctx.canEditPosts || ctx.canDeletePosts || ctx.canFeaturePosts) { %>
             <article class='edit-post'>
                 <% if (ctx.editMode) { %>
                     <a href='<%= ctx.getPostUrl(ctx.post.id, ctx.parameters) %>'>
@@ -36,16 +37,13 @@
                         <span class='vim-nav-hint'>Back to view mode</span>
                     </a>
                 <% } else { %>
-                    <% if (ctx.canEditPosts || ctx.canDeletePosts || ctx.canFeaturePosts) { %>
-                        <a href='<%= ctx.getPostEditUrl(ctx.post.id, ctx.parameters) %>'>
-                    <% } else { %>
-                        <a class='inactive'>
-                    <% } %>
-                        <i class='fa fa-pencil'></i>
-                        <span class='vim-nav-hint'>Edit post</span>
+                    <a href='<%= ctx.getPostEditUrl(ctx.post.id, ctx.parameters) %>'>
+                    <i class='fa fa-pencil'></i>
+                    <span class='vim-nav-hint'>Edit post</span>
                     </a>
                 <% } %>
             </article>
+            <% } %>
         </nav>
 
         <div class='sidebar-container'></div>

From ce613c5adecd7a46e503d887794abfd4b8141517 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Mon, 22 May 2023 13:00:32 +0200
Subject: [PATCH 14/30] client/posts: page exit confirmation for bulk edit
 actions

---
 client/js/views/posts_header_view.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/client/js/views/posts_header_view.js b/client/js/views/posts_header_view.js
index 38a4aa98..58d0ec21 100644
--- a/client/js/views/posts_header_view.js
+++ b/client/js/views/posts_header_view.js
@@ -60,12 +60,14 @@ class BulkSafetyEditor extends BulkEditor {
         e.preventDefault();
         this.toggleOpen(true);
         this.dispatchEvent(new CustomEvent("open", { detail: {} }));
+        misc.enableExitConfirmation();
     }
 
     _evtCloseLinkClick(e) {
         e.preventDefault();
         this.toggleOpen(false);
         this.dispatchEvent(new CustomEvent("close", { detail: {} }));
+        misc.disableExitConfirmation();
     }
 }
 
@@ -130,6 +132,7 @@ class BulkTagEditor extends BulkEditor {
         this.toggleOpen(true);
         this.focus();
         this.dispatchEvent(new CustomEvent("open", { detail: {} }));
+        misc.enableExitConfirmation();
     }
 
     _evtCloseLinkClick(e) {
@@ -138,6 +141,7 @@ class BulkTagEditor extends BulkEditor {
         this.toggleOpen(false);
         this.blur();
         this.dispatchEvent(new CustomEvent("close", { detail: {} }));
+        misc.disableExitConfirmation();
     }
 }
 
@@ -160,12 +164,14 @@ class BulkDeleteEditor extends BulkEditor {
         e.preventDefault();
         this.toggleOpen(true);
         this.dispatchEvent(new CustomEvent("open", { detail: {} }));
+        misc.enableExitConfirmation();
     }
 
     _evtCloseLinkClick(e) {
         e.preventDefault();
         this.toggleOpen(false);
         this.dispatchEvent(new CustomEvent("close", { detail: {} }));
+        misc.disableExitConfirmation();
     }
 }
 

From ae72d7563155ee00cc83f28b76d8177972bd3c43 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Sat, 23 Mar 2024 17:40:25 +0100
Subject: [PATCH 15/30] client/posts: redirect away from /edit when no post
 edit permissions

---
 client/js/controllers/post_main_controller.js | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/client/js/controllers/post_main_controller.js b/client/js/controllers/post_main_controller.js
index 95cfdb52..06f613c3 100644
--- a/client/js/controllers/post_main_controller.js
+++ b/client/js/controllers/post_main_controller.js
@@ -281,7 +281,16 @@ module.exports = (router) => {
         if (ctx.state.parameters) {
             Object.assign(ctx.parameters, ctx.state.parameters);
         }
-        ctx.controller = new PostMainController(ctx, true);
+        const canEditPosts = api.hasPrivilege("posts:edit");
+        if (canEditPosts) {
+            ctx.controller = new PostMainController(ctx, true);
+        } else {
+            router.show(uri.formatClientLink(
+                "post",
+                ctx.parameters.id,
+                ctx.parameters ? { query: ctx.parameters.query } : {}
+            ));
+        }
     });
     router.enter(["post", ":id"], (ctx, next) => {
         // restore parameters from history state

From ae856055317a1e7b86877e12598dc06e79d5b4a8 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Thu, 27 Mar 2025 18:17:00 +0100
Subject: [PATCH 16/30] client/posts: filter out empty post source lines

---
 client/js/models/post.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/js/models/post.js b/client/js/models/post.js
index 2fb3d34c..2025242d 100644
--- a/client/js/models/post.js
+++ b/client/js/models/post.js
@@ -75,7 +75,7 @@ class Post extends events.EventTarget {
     }
 
     get sourceSplit() {
-        return this._source.split("\n");
+        return this._source.split("\n").filter((s) => s);
     }
 
     get canvasWidth() {

From de9b8fdce37577dea76b49350a619063606c4f23 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Fri, 26 May 2023 08:54:55 +0200
Subject: [PATCH 17/30] client/snapshots: display pool name

---
 client/html/snapshots_page.tpl         | 2 +-
 client/js/views/snapshots_page_view.js | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/client/html/snapshots_page.tpl b/client/html/snapshots_page.tpl
index 6650d651..f26ff030 100644
--- a/client/html/snapshots_page.tpl
+++ b/client/html/snapshots_page.tpl
@@ -12,7 +12,7 @@
 
                         <%= item.operation %>
 
-                        <%= ctx.makeResourceLink(item.type, item.id) %>
+                        <%= ctx.makeResourceLink(item.type, item.id, item.data) %>
                     </div>
 
                     <div class='details'><!--
diff --git a/client/js/views/snapshots_page_view.js b/client/js/views/snapshots_page_view.js
index a665ea0d..7a7549e9 100644
--- a/client/js/views/snapshots_page_view.js
+++ b/client/js/views/snapshots_page_view.js
@@ -29,7 +29,7 @@ function _formatBasicChange(diff, text) {
     return lines;
 }
 
-function _makeResourceLink(type, id) {
+function _makeResourceLink(type, id, data) {
     if (type === "post") {
         return views.makePostLink(id, true);
     } else if (type === "tag") {
@@ -37,7 +37,7 @@ function _makeResourceLink(type, id) {
     } else if (type === "tag_category") {
         return 'category "' + id + '"';
     } else if (type === "pool") {
-        return views.makePoolLink(id, true);
+        return views.makePoolLink(id, false, false, data);
     }
 }
 

From 7f2a8b5b07d54c4df2eb9fcd7a69f76b41213e56 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Fri, 28 Mar 2025 19:38:59 +0100
Subject: [PATCH 18/30] client/upload: check "Add relation" box by default

---
 client/html/post_upload_row.tpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/html/post_upload_row.tpl b/client/html/post_upload_row.tpl
index 2885e3d7..62620ee1 100644
--- a/client/html/post_upload_row.tpl
+++ b/client/html/post_upload_row.tpl
@@ -85,7 +85,7 @@
                             <div class='controls'>
                                 <%= ctx.makeCheckbox({text: 'Copy tags', name: 'copy-tags'}) %>
                                 <br/>
-                                <%= ctx.makeCheckbox({text: 'Add relation', name: 'add-relation'}) %>
+                                <%= ctx.makeCheckbox({text: 'Add relation', name: 'add-relation', checked: true}) %>
                             </div>
                         </li>
                     <% } %>

From b2501b7ee2117837a0cc177d29e7fa63c0077b2c Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Fri, 19 May 2023 18:57:10 +0200
Subject: [PATCH 19/30] client/users: default user icon to site favicon for
 anonymous uploads

---
 client/js/util/views.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/js/util/views.js b/client/js/util/views.js
index 38c98a13..23fae598 100644
--- a/client/js/util/views.js
+++ b/client/js/util/views.js
@@ -261,7 +261,7 @@ function makePoolLink(id, includeHash, includeCount, pool, name) {
 }
 
 function makeUserLink(user) {
-    let text = makeThumbnail(user ? user.avatarUrl : null);
+    let text = makeThumbnail(user ? user.avatarUrl : "img/favicon.png");
     text += user && user.name ? misc.escapeHtml(user.name) : "Anonymous";
     const link =
         user && api.hasPrivilege("users:view")

From 9884161297639d4e55b848fc8ae85445756ea860 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Wed, 17 May 2023 22:30:13 +0200
Subject: [PATCH 20/30] client/views: prevent errors on slow connections

---
 client/js/util/views.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/client/js/util/views.js b/client/js/util/views.js
index 23fae598..011c24cf 100644
--- a/client/js/util/views.js
+++ b/client/js/util/views.js
@@ -321,6 +321,7 @@ function emptyContent(target) {
 }
 
 function replaceContent(target, source) {
+    if (!target) return;
     emptyContent(target);
     if (source instanceof NodeList) {
         for (let child of [...source]) {

From ea215901af097aa42c0e6ff4e0f22440d9a3c2a0 Mon Sep 17 00:00:00 2001
From: Hunternif <hunternif@gmail.com>
Date: Sat, 13 Apr 2019 19:39:51 +0700
Subject: [PATCH 21/30] client: add more keybinds, prevent typing when focusing
 input

---
 client/html/help_keyboard.tpl                   | 10 ++++++++++
 client/js/controls/post_edit_sidebar_control.js | 11 +++++++++++
 client/js/util/keyboard.js                      |  9 +++++++++
 client/js/util/search.js                        |  3 ++-
 4 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/client/html/help_keyboard.tpl b/client/html/help_keyboard.tpl
index f200ce02..98b807b7 100644
--- a/client/html/help_keyboard.tpl
+++ b/client/html/help_keyboard.tpl
@@ -34,6 +34,16 @@ shortcuts:</p>
             <td>Focus first post in post list</td>
         </tr>
 
+        <tr>
+            <td><kbd>T</kbd></td>
+            <td>(In edit mode) Focus tag input</td>
+        </tr>
+
+        <tr>
+            <td><kbd>Command/Ctrl+S</kbd></td>
+            <td>(In edit mode) Save post</td>
+        </tr>
+
         <tr>
             <td><kbd>Delete</kbd></td>
             <td>Delete post (while in edit mode)</td>
diff --git a/client/js/controls/post_edit_sidebar_control.js b/client/js/controls/post_edit_sidebar_control.js
index 46f56c6d..d5d4558c 100644
--- a/client/js/controls/post_edit_sidebar_control.js
+++ b/client/js/controls/post_edit_sidebar_control.js
@@ -4,6 +4,7 @@ const api = require("../api.js");
 const events = require("../events.js");
 const misc = require("../util/misc.js");
 const views = require("../util/views.js");
+const keyboard = require("../util/keyboard.js");
 const Note = require("../models/note.js");
 const Point = require("../models/point.js");
 const TagInputControl = require("./tag_input_control.js");
@@ -243,6 +244,16 @@ class PostEditSidebarControl extends events.EventTarget {
                 this._syncExpanderTitles();
             });
         }
+
+        keyboard.bind(["command+s", "ctrl+s"], (e) => this._evtSubmit(e));
+        if (this._tagInputNode) {
+            const realTagInput = this._formNode.querySelector(".tag-input input");
+            keyboard.bindElement(realTagInput, ["command+s", "ctrl+s"], (e) => this._evtSubmit(e));
+            keyboard.bind("t", (e) => {
+                e.preventDefault();
+                realTagInput.focus();
+            });
+        }
     }
 
     _syncExpanderTitles() {
diff --git a/client/js/util/keyboard.js b/client/js/util/keyboard.js
index 3fe32633..c54b089d 100644
--- a/client/js/util/keyboard.js
+++ b/client/js/util/keyboard.js
@@ -22,12 +22,21 @@ function bind(hotkey, func) {
     return false;
 }
 
+function bindElement(element, hotkey, func) {
+    if (settings.get().keyboardShortcuts) {
+        mousetrap(element).bind(hotkey, func);
+        return true;
+    }
+    return false;
+}
+
 function unbind(hotkey) {
     mousetrap.unbind(hotkey);
 }
 
 module.exports = {
     bind: bind,
+    bindElement: bindElement,
     unbind: unbind,
     pause: () => {
         paused = true;
diff --git a/client/js/util/search.js b/client/js/util/search.js
index c540c2f1..d915769b 100644
--- a/client/js/util/search.js
+++ b/client/js/util/search.js
@@ -5,7 +5,8 @@ const keyboard = require("../util/keyboard.js");
 const views = require("./views.js");
 
 function searchInputNodeFocusHelper(inputNode) {
-    keyboard.bind("q", () => {
+    keyboard.bind("q", (e) => {
+        e.preventDefault();
         inputNode.focus();
         inputNode.setSelectionRange(
             inputNode.value.length,

From 0b02826e6dfe8187fc4ea9ade08840b13d9d2b75 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Fri, 28 Mar 2025 17:33:57 +0100
Subject: [PATCH 22/30] client: apply dark theme without a page reload I'm
 really confused why the user was expected to reload the page, there's no
 technical reason that I can find for it to be this way.

---
 client/html/settings.tpl     | 1 -
 client/js/models/settings.js | 5 +++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/client/html/settings.tpl b/client/html/settings.tpl
index 0edbe22b..4c19c0d5 100644
--- a/client/html/settings.tpl
+++ b/client/html/settings.tpl
@@ -28,7 +28,6 @@
                     name: 'dark-theme',
                     checked: ctx.browsingSettings.darkTheme,
                 }) %>
-                <p class='hint'>Changing this setting will require you to refresh the page for it to apply.</p>
             </li>
 
             <li>
diff --git a/client/js/models/settings.js b/client/js/models/settings.js
index b39f07fa..8dfe4b3a 100644
--- a/client/js/models/settings.js
+++ b/client/js/models/settings.js
@@ -40,6 +40,11 @@ class Settings extends events.EventTarget {
     save(newSettings, silent) {
         newSettings = Object.assign(this.cache, newSettings);
         localStorage.setItem("settings", JSON.stringify(newSettings));
+        if (newSettings.darkTheme) {
+            document.body.classList.add("darktheme");
+        } else {
+            document.body.classList.remove("darktheme");
+        }
         this.cache = this._getFromLocalStorage();
         if (silent !== true) {
             this.dispatchEvent(

From 86bbd429f7678eb7c3097c85c9ac131d59669410 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Sat, 29 Mar 2025 07:10:55 +0100
Subject: [PATCH 23/30] client: apply theme as soon as possible Fixes the
 default theme flashing on reload

---
 client/js/main.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/client/js/main.js b/client/js/main.js
index c5bdc537..847cd0d1 100644
--- a/client/js/main.js
+++ b/client/js/main.js
@@ -42,6 +42,10 @@ const pools = require("./pools.js");
 const api = require("./api.js");
 const settings = require("./models/settings.js");
 
+if (settings.get().darkTheme) {
+    document.body.classList.add("darktheme");
+}
+
 Promise.resolve()
     .then(() => api.fetchConfig())
     .then(

From 7f6211e0ccaed358cffd9bf07c64659ef790aab6 Mon Sep 17 00:00:00 2001
From: Hunternif <hunternif@gmail.com>
Date: Mon, 22 Apr 2019 23:22:04 +0700
Subject: [PATCH 24/30] client: fix displaying 0 in number inputs

---
 client/js/util/views.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/client/js/util/views.js b/client/js/util/views.js
index 011c24cf..3a721b35 100644
--- a/client/js/util/views.js
+++ b/client/js/util/views.js
@@ -111,7 +111,7 @@ function makeSelect(options) {
 }
 
 function makeInput(options) {
-    options.value = options.value || "";
+    options.value = options.value === 0 ? 0 : options.value || "";
     return _makeLabel(options) + makeElement("input", options);
 }
 
@@ -300,6 +300,8 @@ function _serializeElement(name, attributes) {
                     attributes[key] === undefined
                 ) {
                     return "";
+                } else if (attributes[key] === 0) {
+                    return `${key}="0"`;
                 }
                 const attribute = misc.escapeHtml(attributes[key] || "");
                 return `${key}="${attribute}"`;

From 2b06e1cafa81cddd790121ee7957d39125c007c4 Mon Sep 17 00:00:00 2001
From: Hunternif <hunternif@gmail.com>
Date: Sun, 16 Feb 2025 18:46:02 +0000
Subject: [PATCH 25/30] client: fix weird Chrome bug where video controls are
 invisible under div class="transparent"

---
 client/css/core-general.styl | 4 ++--
 client/html/home.tpl         | 2 +-
 client/html/post_main.tpl    | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/client/css/core-general.styl b/client/css/core-general.styl
index 430848b7..65b0852d 100644
--- a/client/css/core-general.styl
+++ b/client/css/core-general.styl
@@ -111,7 +111,7 @@ form .fa-question-circle-o
                     margin-right: 1em
                     a
                         color: $button-enabled-text-color
-    >.content-wrapper:not(.transparent)
+    >.content-wrapper:not(.transparent-container)
         background: $top-navigation-color
         padding: 1.8em
         @media (max-width: 1000px)
@@ -122,7 +122,7 @@ form .fa-question-circle-o
                 margin-bottom: 0
 
 .darktheme #content-holder
-    >.content-wrapper:not(.transparent)
+    >.content-wrapper:not(.transparent-container)
         background: $top-navigation-color-darktheme
 
 hr
diff --git a/client/html/home.tpl b/client/html/home.tpl
index 1e51b12b..36946b45 100644
--- a/client/html/home.tpl
+++ b/client/html/home.tpl
@@ -1,4 +1,4 @@
-<div class='content-wrapper transparent' id='home'>
+<div class='content-wrapper transparent-container' id='home'>
     <div class='messages'></div>
     <header>
         <h1><%- ctx.name %></h1>
diff --git a/client/html/post_main.tpl b/client/html/post_main.tpl
index 62a009b0..434dc86d 100644
--- a/client/html/post_main.tpl
+++ b/client/html/post_main.tpl
@@ -1,4 +1,4 @@
-<div class='content-wrapper transparent post-view'>
+<div class='content-wrapper transparent-container post-view'>
     <aside class='sidebar'>
         <nav class='buttons'>
             <article class='previous-post'>

From 2ed19e013a32367adee03a5876a0619d3aa20cfc Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Wed, 20 Mar 2024 22:38:04 +0100
Subject: [PATCH 26/30] server/posts: more thorough error exception

---
 server/szurubooru/api/post_api.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/szurubooru/api/post_api.py b/server/szurubooru/api/post_api.py
index daba7f7e..6ce1944d 100644
--- a/server/szurubooru/api/post_api.py
+++ b/server/szurubooru/api/post_api.py
@@ -21,7 +21,7 @@ _search_executor = search.Executor(_search_executor_config)
 def _get_post_id(params: Dict[str, str]) -> int:
     try:
         return int(params["post_id"])
-    except TypeError:
+    except (TypeError, ValueError):
         raise posts.InvalidPostIdError(
             "Invalid post ID: %r." % params["post_id"]
         )

From 8acd6ab776bbb49b1beaafc5e14f6cbc283edc7d Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Thu, 25 May 2023 12:21:41 +0200
Subject: [PATCH 27/30] server/search: add safety search synonyms

---
 server/szurubooru/search/configs/post_search_config.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/server/szurubooru/search/configs/post_search_config.py b/server/szurubooru/search/configs/post_search_config.py
index ddc003b7..81fd874c 100644
--- a/server/szurubooru/search/configs/post_search_config.py
+++ b/server/szurubooru/search/configs/post_search_config.py
@@ -32,9 +32,13 @@ def _type_transformer(value: str) -> str:
 def _safety_transformer(value: str) -> str:
     available_values = {
         "safe": model.Post.SAFETY_SAFE,
+        "s": model.Post.SAFETY_SAFE,
         "sketchy": model.Post.SAFETY_SKETCHY,
         "questionable": model.Post.SAFETY_SKETCHY,
+        "q": model.Post.SAFETY_SKETCHY,
         "unsafe": model.Post.SAFETY_UNSAFE,
+        "explicit": model.Post.SAFETY_UNSAFE,
+        "e": model.Post.SAFETY_UNSAFE,
     }
     return search_util.enum_transformer(available_values, value)
 

From d3c2da4f916bcc3a491831ae3ac167ea3da751c4 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Sun, 21 May 2023 09:26:17 +0200
Subject: [PATCH 28/30] server/upload: disable default loop flag for videos,
 detect gif loop

---
 server/szurubooru/func/images.py | 5 +++++
 server/szurubooru/func/posts.py  | 6 ++++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/server/szurubooru/func/images.py b/server/szurubooru/func/images.py
index e135d182..e34039e2 100644
--- a/server/szurubooru/func/images.py
+++ b/server/szurubooru/func/images.py
@@ -24,6 +24,11 @@ def convert_heif_to_png(content: bytes) -> bytes:
     return img_byte_arr.getvalue()
 
 
+def check_for_loop(content: bytes) -> bytes:
+    img = PILImage.open(BytesIO(content))
+    return "loop" in img.info
+
+
 class Image:
     def __init__(self, content: bytes) -> None:
         self.content = content
diff --git a/server/szurubooru/func/posts.py b/server/szurubooru/func/posts.py
index be2259cf..ac10a4af 100644
--- a/server/szurubooru/func/posts.py
+++ b/server/szurubooru/func/posts.py
@@ -531,8 +531,10 @@ def generate_alternate_formats(
 def get_default_flags(content: bytes) -> List[str]:
     assert content
     ret = []
-    if mime.is_video(mime.get_mime_type(content)):
-        ret.append(model.Post.FLAG_LOOP)
+    if mime.is_animated_gif(content):
+        if images.check_for_loop(content):
+            ret.append(model.Post.FLAG_LOOP)
+    elif mime.is_video(mime.get_mime_type(content)):
         if images.Image(content).check_for_sound():
             ret.append(model.Post.FLAG_SOUND)
     return ret

From b3fa26b3fbd67a75ca958057317603e98c009187 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Fri, 28 Mar 2025 19:32:50 +0100
Subject: [PATCH 29/30] client/api: set json mime type for metadata

---
 client/js/api.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/js/api.js b/client/js/api.js
index 5bde6d81..706c9458 100644
--- a/client/js/api.js
+++ b/client/js/api.js
@@ -398,7 +398,7 @@ class Api extends events.EventTarget {
 
             if (data) {
                 if (files && Object.keys(files).length) {
-                    req.attach("metadata", new Blob([JSON.stringify(data)]));
+                    req.attach("metadata", new Blob([JSON.stringify(data)], { type: "application/json" }));
                 } else {
                     req.set("Content-Type", "application/json");
                     req.send(data);

From acb1eddb5346b6908bc8d4873c73f7d4374e4115 Mon Sep 17 00:00:00 2001
From: Eva <evauwu@riseup.net>
Date: Sun, 30 Mar 2025 07:43:44 +0200
Subject: [PATCH 30/30] client/css: text input focus outline

---
 client/css/core-forms.styl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/client/css/core-forms.styl b/client/css/core-forms.styl
index c75e81ae..1bfceefe 100644
--- a/client/css/core-forms.styl
+++ b/client/css/core-forms.styl
@@ -206,6 +206,7 @@ input[type=number]
     background: $input-enabled-background-color
     color: $input-enabled-text-color
     box-shadow: none /* :-moz-submit-invalid on FF */
+    outline: none
     transition: border-color 0.1s linear, background-color 0.1s linear
 
     &:disabled
@@ -214,7 +215,7 @@ input[type=number]
         color: $input-disabled-text-color
 
     &:focus
-        border-color: $main-color
+        border-color: $main-color !important
 
     &[readonly]
         border: 2px solid $input-disabled-border-color